search

thoth-station / prescriptions

⚕️💊 Prescriptions to heal your applications and application dependencies 💊⚕️
https://thoth-station.ninja/docs/developers/adviser/prescription.html
GNU Affero General Public License v3.0
17 stars 10 forks source link

validate prescriptions with pre-commit hook using adviser #38951

Closed VannTen closed 1 year ago

VannTen commented 1 year ago

Related Issues and Dependencies

fix #8 thoth-station/adviser#2402

This introduces a breaking change

This should yield a new module release

This Pull Request implements

Add a pre-commit hooks to validate prescriptions. In conjonction with --from-ref / --to-ref, this should only validates files touched in a PR

This on my fork of thoth-station/adviser because it needs thoth-station/adviser#2411 and thoth-station#2408 to be merged first.

By the way, we really need operate-first/apps#2462 on this repo. It would allow us to implement pre-commit hook caching instead of installing every single time, which would save a lot of prow-time. (well, once it comes back up...)

/hold

goern commented 1 year ago

/test all

VannTen commented 1 year ago

/unhold

VannTen commented 1 year ago

of course I had to forget the other pre-commit hooks :/

codificat commented 1 year ago

/lgtm /approve

thanks!

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/prescriptions/blob/master/OWNERS)~~ [codificat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment