search

thoth-station / python

Library for Python related code
GNU General Public License v3.0
4 stars 12 forks source link

Artifacts for gym_donkeycar on Pulp not properly recognized #450

Closed fridex closed 2 years ago

fridex commented 2 years ago

Describe the bug

See artifact gym_donkeycar-1.1.1-py2.py3-none-any.whl on opf's Pulp instance:

https://pulp.operate-first.cloud/pulp/content/gym-donkeycar/gym_donkeycar-1.1.1-py2.py3-none-any.whl#sha256=cdc784babaec238a9a1d8fe26cc7f6571e888a9131e0dc16b8916ce407e70cc7

The name of this artifact is not properly recognized. The bug appears when checking artifact names in the code:

https://github.com/thoth-station/python/blob/fbdd9d2cf3acc437180dfd84b135bc9687e796f2/thoth/python/source.py#L346

This causes no artifact is found and makes issues in the cross-index resolution.

To Reproduce Steps to reproduce the behavior:

  1. Go a Thoth deployment
  2. Schedule solving of gym-donkeycar
  3. Check solver document
  4. See no artifact hashes in the solver document as no artifact is found

Expected behavior

Artifact hashes should be reported by thoth-solver.

Related: https://github.com/thoth-station/thoth-application/issues/2272

fridex commented 2 years ago

/priority critical-urgent