Iterate over each artifacts instead of capturing in a list

[harshad16]

Iterate over each artifacts instead of capturing in a list Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related Issues and Dependencies

Related-to: https://github.com/thoth-station/thoth-application/issues/2690#issuecomment-1331752960

Description

• Moved the function code get_package_artifacts directly into get_package_hashes As each artifact object, is linked to the downloaded artifacts, they get deleted on obj deletion. With this , each artifact would be live for short period till the hash is gathered.

Each artifact would be iterated one after another, instead of gathering them all in one list.

• The function get_package_data didn't seem to be used anywhere so it is now merged in get_package_hashes

[sesheta]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mayaCostantini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/python/blob/master/OWNERS)~~ [mayaCostantini] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[sesheta]

@harshad16: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
aicoe-ci/prow/pre-commit	e2fb2cab51e9c1fc6610109b7ca9942ae7a7c6e5	link	true	/test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[harshad16]

Merging it for release.