search

thoth-station / python

Library for Python related code
GNU General Public License v3.0
4 stars 12 forks source link

`packaging` deprecates `LegacyVersion` causing failure if `packaging` is upgraded #488

Open Gkrumbach07 opened 1 year ago

Gkrumbach07 commented 1 year ago

Bug description

Version 0.22 of packaging deprecates LegacyVersion and LegacySpecifier which are used in this module.

Steps to Reproduce

  1. upgrade to latest version of packaging
  2. run anything

Actual behavior

module crashes

Expected behavior

module does not crash

Additional context

usage of deprecated functions are found here: https://github.com/thoth-station/python/search?q=LegacyVersion

dejanb commented 1 year ago

I ran into the same issue, trying to install it on the clean box

pip3 install packaging==21.3

got me going. I can help with the PR, just wondering what's the desired solution here. Remove dependency on LegacyVersion or find a way to preserve functionality with the newer versions?

codificat commented 1 year ago

We should probably remove it eventually, but I am not sure how/if this is still used in other packages that rely on thoth-python. /sig stack-guidance