search

thoth-station / python

Library for Python related code
GNU General Public License v3.0
4 stars 12 forks source link

Limit packaging to <22 #489

Closed VannTen closed 1 year ago

VannTen commented 1 year ago

Temp fix

Related Issues and Dependencies

thoth-station/adviser#2404 thoth-station/adviser#2405

Context : pypa/packaging#321

This introduces a breaking change

This should yield a new module release

Description

Stop-gap fix. We'll need to adpat to packaging version >21 eventually

VannTen commented 1 year ago

Can we get rid of requirements.txt and use setuptools-pipfile to avoid having two files to maintain ?

harshad16 commented 1 year ago

Can we get rid of requirements.txt and use setuptools-pipfile to avoid having two files to maintain ?

yeah sounds good

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/python/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment