search

thoth-station / s2i-generic-data-science-notebook

GNU General Public License v3.0
2 stars 14 forks source link

Include jupyterlab-s3-browser extension #15

Closed MichaelClifford closed 3 years ago

MichaelClifford commented 3 years ago

Is your feature request related to a problem? Please describe.

I'm always frustrated when I have to use the s3cmd command line tool to see what's in my remote storage. It would be great if I could navigate ceph the same way I navigate my PVC files.

Describe the solution you'd like

I would like the jupyterlab-s3-browser extension added to the jupyterlab notebooks.

Describe alternatives you've considered

No other alternatives have been proposed for GUI lab/notebook s3 exploration. There are CLI tools, python API's and the Hue S3 browser. However, I think this lab extension is far faster, easier and more reliable to use than all of these alternatives.

Additional context Add any other context or screenshots about the feature request here.

pacospace commented 3 years ago

Is your feature request related to a problem? Please describe.

I'm always frustrated when I have to use the s3cmd command line tool to see what's in my remote storage. It would be great if I could navigate ceph the same way I navigate my PVC files.

Describe the solution you'd like

I would like the jupyterlab-s3-browser extension added to the jupyterlab notebooks.

Describe alternatives you've considered

No other alternatives have been proposed for GUI lab/notebook s3 exploration. There are CLI tools, python API's and the Hue S3 browser. However, I think this lab extension is far faster, easier and more reliable to use than all of these alternatives.

Additional context Add any other context or screenshots about the feature request here.

Thanks @MichaelClifford!! Really nice extension, I think it can be interesting also for ODH downstream! I don't see big constraints to have it.

pacospace commented 3 years ago

cc @crobby @guimou @cfchase

LaVLaS commented 3 years ago

I think we should investigate adding this to s2i-generic-data-science-notebook since it is including the boto3 package with the expectation that a user will need an s3 library

pacospace commented 3 years ago

I think we should investigate adding this to s2i-generic-data-science-notebook since it is including the boto3 package with the expectation that a user will need an s3 library

It will be there if we add it to s2i-minimal-notebook as it is the base image for that, while @MichaelClifford requested it for the s2i-lab-elyra image.

cfchase commented 3 years ago

I think we should investigate adding this to s2i-generic-data-science-notebook since it is including the boto3 package with the expectation that a user will need an s3 library

Good point. I'm wondering if adding the s3 extension makes this minimal notebook more than just minimal? Adding it to the s2i-generic-data-science-notebook would also add it to elyra, would it not?

pacospace commented 3 years ago

I think we should investigate adding this to s2i-generic-data-science-notebook since it is including the boto3 package with the expectation that a user will need an s3 library

Good point. I'm wondering if adding the s3 extension makes this minimal notebook more than just minimal? Adding it to the s2i-generic-data-science-notebook would also add it to elyra, would it not?

Nope, they use same base image (quay.io/thoth-station/s2i-minimal-py38-notebook) but they have different packages.

pacospace commented 3 years ago

I think we should investigate adding this to s2i-generic-data-science-notebook since it is including the boto3 package with the expectation that a user will need an s3 library

Good point. I'm wondering if adding the s3 extension makes this minimal notebook more than just minimal? Adding it to the s2i-generic-data-science-notebook would also add it to elyra, would it not?

Good point for not being minimal anymore, but I guess boto3 should be a minimal package to interact with s3 compatible object storages. Or we can create a layer on top of this for jupyterlab extensions required by users.

harshad16 commented 3 years ago

very good points all

Maybe it would be good to make generic base for elyra as well , then user of the elyra would have other ds related packages to use.

harshad16 commented 3 years ago

great i see some +1 on the previous comment i will move this to the generic notebook and get started there.

goern commented 3 years ago

/kind feature /sig user-experience

harshad16 commented 3 years ago

version v0.0.3 has the required changes. This pr should close this issue. https://github.com/opendatahub-io/odh-manifests/pull/394

goern commented 3 years ago

looks like the upstream issue is closed/merged, feel free to re-open if required

/close

sesheta commented 3 years ago

@goern: Closing this issue.

In response to [this](https://github.com/thoth-station/s2i-generic-data-science-notebook/issues/15#issuecomment-861377020): >looks like the upstream issue is closed/merged, feel free to re-open if required > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.