thoth-station / s2i-generic-data-science-notebook

GNU General Public License v3.0

2 stars 14 forks source link

Introduce jupyterlab-git extension #6

Closed pacospace closed 3 years ago

pacospace commented 3 years ago

Signed-off-by: Francesco Murdaca fmurdaca@redhat.com

Related Issues and Dependencies

Fixes: https://github.com/thoth-station/s2i-generic-data-science-notebook/issues/1

Description

Add jupyterlab-git extension compatible with Jupyterlab >=3.*

sesheta commented 3 years ago

@pacospace: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
aicoe-ci/prow/pre-commit	10615064fab4f8c263a7f869618adeeddb05c871	link	`/test pre-commit`

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

harshad16 commented 3 years ago

@pacospace these changes are already present in the repository.

pacospace commented 3 years ago

@pacospace these changes are already present in the repository.

Actually, the jupyterlab-git extension compatible with jupyterlab3 in version v0.0.1 is missing: https://github.com/thoth-station/s2i-generic-data-science-notebook/blob/4378a93c814a58e78286f325eb7c074c2d06bb01/Pipfile.lock#L463, it should be : https://pypi.org/project/jupyterlab-git/0.30.0b2/

pacospace commented 3 years ago

@pacospace these changes are already present in the repository.

Ref: https://github.com/thoth-station/s2i-generic-data-science-notebook/issues/1#issuecomment-810304264

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/s2i-generic-data-science-notebook/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment