search

thoth-station / s2i-thoth

Thoth's addition to OpenShift's s2i Python builds to benefit from Thoth's recommendations in your application
GNU General Public License v3.0
6 stars 19 forks source link

Bump thamos to v1.18.1 #174

Closed fridex closed 3 years ago

fridex commented 3 years ago

Related Issues and Dependencies

Related: https://github.com/thoth-station/thamos/pull/850

This introduces a breaking change

sesheta commented 3 years ago

@fridex: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
aicoe-ci/prow/pre-commit e2eb4edbfadb14a5bf5f6c49ca3810c395e04866 link /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
fridex commented 3 years ago

Not sure if s2i is affected by the fix addressed in thamos==1.18.1 (probably not).

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/s2i-thoth/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment