search

thoth-station / s2i-thoth

Thoth's addition to OpenShift's s2i Python builds to benefit from Thoth's recommendations in your application
GNU General Public License v3.0
6 stars 19 forks source link

Allow users to generate thoth configuration during the build process #190

Closed fridex closed 3 years ago

fridex commented 3 years ago

Related Issues and Dependencies

Related: https://github.com/thoth-station/s2i-thoth/issues/189

This introduces a breaking change

fridex commented 3 years ago

I will open the flag for disabling all the thoth in a separate PR.

goern commented 3 years ago

What is the status of this?

fridex commented 3 years ago

/approve

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex, KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/s2i-thoth/blob/master/OWNERS)~~ [fridex] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment