thoth-station / s2i-thoth

Thoth's addition to OpenShift's s2i Python builds to benefit from Thoth's recommendations in your application
GNU General Public License v3.0
6 stars 19 forks source link

Do not use curl but copy requirements.txt #210

Closed pacospace closed 3 years ago

pacospace commented 3 years ago

Related Issues and Dependencies

See issue: https://github.com/sclorg/s2i-python-container/issues/466#issuecomment-888949810 Fixes: https://github.com/thoth-station/s2i-thoth/issues/201

This introduces a breaking change

This Pull Request implements

COPY requirements txt instead of using curl

pacospace commented 3 years ago

/assign @harshad16

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/s2i-thoth/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment