search

thoth-station / s2i-thoth

Thoth's addition to OpenShift's s2i Python builds to benefit from Thoth's recommendations in your application
GNU General Public License v3.0
6 stars 19 forks source link

Thoth Configuration Initialization #215

Closed khebhut[bot] closed 2 years ago

khebhut[bot] commented 3 years ago

Automatic configuration initialization

The Kebechet app was installed on this repository but no configuration was found. This PR contains basic configuration of runtime environments and managers.

sesheta commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign fridex after the PR has been reviewed. You can assign the PR to them by writing /assign @fridex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/s2i-thoth/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 3 years ago

Hi @khebhut[bot]. Thanks for your PR.

I'm waiting for a thoth-station member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
KPostOffice commented 3 years ago

/hold This should not be merged as the repo doesn't contain python code. We will discuss what the default .thoth.yaml file should look like in the upcoming tech talk

KPostOffice commented 2 years ago

This has been handled by having the default configuration add all managers but making them all disabled by default. /close

sesheta commented 2 years ago

@KPostOffice: Closed this PR.

In response to [this](https://github.com/thoth-station/s2i-thoth/pull/215#issuecomment-971904541): >This has been handled by having the default configuration add all managers but making them all disabled by default. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.