Pip no cache dir - Githubissues

thoth-station / s2i-thoth

Thoth's addition to OpenShift's s2i Python builds to benefit from Thoth's recommendations in your application

GNU General Public License v3.0

6 stars 19 forks source link

Pip no cache dir #216

Closed guimou closed 2 years ago

guimou commented 2 years ago

This introduces a breaking change

[ ] Yes
[X ] No

This Pull Request implements

Fix the version of the base image registry.fedoraproject.org/f34/python3. With latest the assemble patch was not valid anymore. Other solution would be to constantly maintain the assemble patch to reflect changes in base image.
Added the no-cache-dir option to the all the pip install to minimize the image size.

sesheta commented 2 years ago

Hi @guimou. Thanks for your PR.

I'm waiting for a thoth-station member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

goern commented 2 years ago

/lgtm assign @fridex

goern commented 2 years ago

/ok-to-test /assign @fridex

ping https://github.com/thoth-station/thoth-application/issues/1961

goern commented 2 years ago

/assign @guimou please have a look at the pre-commit issues, thx!!

guimou commented 2 years ago

/assign @guimou please have a look at the pre-commit issues, thx!!

I'd like to, but when I click on the Details link it opens the Prow page but it is empty. I only get the tile "pre-commit #1441629034663383040" then nothing...

fridex commented 2 years ago

/assign @guimou please have a look at the pre-commit issues, thx!!

I'd like to, but when I click on the Details link it opens the Prow page but it is empty. I only get the tile "pre-commit #1441629034663383040" then nothing...

You can run pre-commit locally until these issues get resolved.

sesheta commented 2 years ago

New changes are detected. LGTM label has been removed.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/s2i-thoth/blob/master/OWNERS)~~ [fridex] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment