thoth-station / s2i-thoth

Thoth's addition to OpenShift's s2i Python builds to benefit from Thoth's recommendations in your application
GNU General Public License v3.0
6 stars 19 forks source link

Update to thamos v1.24.0 #229

Closed fridex closed 2 years ago

fridex commented 2 years ago

This introduces a breaking change

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from fridex after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/s2i-thoth/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
fridex commented 2 years ago

/assign @harshad16

sesheta commented 2 years ago

@fridex: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit c59d8cb215b660fccee0b75db7a0cac307db527a link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
codificat commented 2 years ago

By now, we probably want the latest tag (v1.27.2) instead, right?

About the pre-commit failure: a quick check here reports that the remove-tabs hook is not happy with the ubi*/s2i_assemble.patch files.

goern commented 2 years ago

/assign @fridex

goern commented 2 years ago

@Gregory-Pereira maybe you can work on this too?

Gregory-Pereira commented 2 years ago

@Gregory-Pereira maybe you can work on this too?

:+1: /assign

fridex commented 2 years ago

Oh, nice. I will close this PR as it will most probably need an update of deps in a separate pr.

fridex commented 2 years ago

/close 👍🏻