thoth-station / s2i-thoth

Thoth's addition to OpenShift's s2i Python builds to benefit from Thoth's recommendations in your application
GNU General Public License v3.0
6 stars 19 forks source link

update churn #238

Closed goern closed 2 years ago

goern commented 2 years ago
sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from goern after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/s2i-thoth/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
goern commented 2 years ago

/assign @gregory-pereira /assign @harshad16

mayaCostantini commented 2 years ago

/lgtm The new version of Thamos has been released so I think it should be good to go.

Gregory-Pereira commented 2 years ago

I tested each overlay from your forked branch, not sure if I am building them wrong but they don't have access to the thamos cli, not sure if it is needed...

$ podman build -f f34-py39/Dockerfile -t f34-py39;
$ podman build -f f35-py310/Dockerfile -t f35-py310;
$ podman build -f ubi8-py38/Dockerfile -t ubi8-py38;
$ podman build -f ubi8-py39/Dockerfile -t ubi8-py39;
$ podman build -f ubi8-py36/Dockerfile -t ubi8-py36;

$ podman run --rm -it <each image tag> bash
(app-root) which thamos
bash: thamos: command not found
(app-root) pip list
Package    Version
---------- -------
pip        21.0.1
setuptools 39.2.0
wheel      0.31.1
sesheta commented 2 years ago

New changes are detected. LGTM label has been removed.

sesheta commented 2 years ago

New changes are detected. LGTM label has been removed.

Gregory-Pereira commented 2 years ago

The f34-py39 overlay is looking for pip3 binary at path /usr/pin/pip3. Either use its current path /opt/app-root/bin/pip3 or copy it to /usr/bin. This entails modifying these two lines in your fork. This also causes build to fail, but after this change and the thamos hash, it builds successfully.

Gregory-Pereira commented 2 years ago

Same changes apply to the f35-py310 overlay as the f34-py39 overlay.

  1. change these lines to use /opt/app-root/bin/pip3 instead of /usr/bin/pip3.
  2. change these lines to use the correct hashes:
    --hash=sha256:8def2131b43f0a6fb157f80dfb277ebfce387155ffb7e3da86b12ba5eef2be44 \
    --hash=sha256:d5d69c900b8ca90ff2feb9b89d358abddfbfb2c580359966206b93253a3019a2

    After these changes the f35-py310 overlay builds successfully.

Gregory-Pereira commented 2 years ago

Same changes apply to the ubi8-py38 overlay as the f34-py39 overlay.

  1. change these lines to use /opt/app-root/bin/pip3 instead of /usr/bin/pip3.
  2. change these lines to use the correct hashes:
    --hash=sha256:8def2131b43f0a6fb157f80dfb277ebfce387155ffb7e3da86b12ba5eef2be44 \
    --hash=sha256:d5d69c900b8ca90ff2feb9b89d358abddfbfb2c580359966206b93253a3019a2

    After these changes the ubi8-py38 overlay builds successfully.

Gregory-Pereira commented 2 years ago

Same changes apply to the ubi8-py39 overlay as the f34-py39 overlay.

  1. change these lines to use /opt/app-root/bin/pip3 instead of /usr/bin/pip3.
  2. change these lines to use the correct hashes:
    --hash=sha256:8def2131b43f0a6fb157f80dfb277ebfce387155ffb7e3da86b12ba5eef2be44 \
    --hash=sha256:d5d69c900b8ca90ff2feb9b89d358abddfbfb2c580359966206b93253a3019a2

    After these changes the ubi8-py39 overlay builds successfully.

Gregory-Pereira commented 2 years ago

The changes for the ubi8-py36 overlay are similar but not exactly the same. You should change these lines to use /opt/app-root/bin/pip3 instead of /usr/bin/pip3 as with the over overlays.

However, The difference is that the thamos version is set to 1.27.3 instead of 1.27.4. If this difference in the thamos version is intentional skip this step, but if not, additionally alter the hashes for the thamos version by changing these lines to use the correct hashes:

    --hash=sha256:8def2131b43f0a6fb157f80dfb277ebfce387155ffb7e3da86b12ba5eef2be44 \
    --hash=sha256:d5d69c900b8ca90ff2feb9b89d358abddfbfb2c580359966206b93253a3019a2

Either way, after these changes the ubi8-py36 overlay builds successfully.

goern commented 2 years ago

@Gregory-Pereira thanks for the deep look at it!! :100: actually, you could contribute these changes to my pr

harshad16 commented 2 years ago

Thanks, everyone for your contributions and reviews