search

thoth-station / s2i-thoth

Thoth's addition to OpenShift's s2i Python builds to benefit from Thoth's recommendations in your application
GNU General Public License v3.0
6 stars 19 forks source link

installing python3.8 and bumping version of thamos to latest #239

Closed Gregory-Pereira closed 2 years ago

Gregory-Pereira commented 2 years ago

Related Issues and Dependencies

Addresses: https://github.com/thoth-station/support/issues/204

This introduces a breaking change

This Pull Request implements

Bumping version of thamos, installing python3.8 so thamos install does not fail, adding other transative dependency of rich_click

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign fridex after the PR has been reviewed. You can assign the PR to them by writing /assign @fridex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/s2i-thoth/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sesheta commented 2 years ago

@Gregory-Pereira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit dd9418a4186d51a43e4523b0fee8861c01c1dde0 link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Gregory-Pereira commented 2 years ago

Closing this issue, is already being addressed by #238 .