thoth-station / s2i-thoth

Thoth's addition to OpenShift's s2i Python builds to benefit from Thoth's recommendations in your application
GNU General Public License v3.0
6 stars 19 forks source link

creating ubi9-py39 overlay #252

Closed Gregory-Pereira closed 1 year ago

Gregory-Pereira commented 2 years ago

Related Issues and Dependencies

Addresses: https://github.com/thoth-station/s2i-thoth/issues/234

This introduces a breaking change

This Pull Request implements

Adding a new ubi9 solver image.

Description

Not entirely sure about the s2i-patch, going to test it.

/cc @harshad16

sesheta commented 2 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

goern commented 2 years ago

a root cause for this to fail build seems to be

Collecting requests==2.28.1
  Downloading requests-2.28.1-py3-none-any.whl (62 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 62.8/62.8 kB 1.4 MB/s eta 0:00:00
Installing collected packages: requests
  Attempting uninstall: requests
    Found existing installation: requests 2.25.1
ERROR: Cannot uninstall requests 2.25.1, RECORD file not found. Hint: The package was installed by rpm.
09-06-22 14:04:55 micropipenv  ERROR  Failed to install requirements, dependency 'requests' could not be installed

so this is pip trying to update requests to the version specified in resq.txt, therefor trying to uninstall requests first, which fails, as it is in the container image via rpm :/

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/s2i-thoth/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment