thoth-station / s2i-thoth

Thoth's addition to OpenShift's s2i Python builds to benefit from Thoth's recommendations in your application
GNU General Public License v3.0
6 stars 19 forks source link

:put_litter_in_its_place: deprecate Python 3.8 based images, as it is end-of-life, see https://devguide.python.org/versions/\#unsupported-versions #255

Closed goern closed 2 years ago

goern commented 2 years ago

Signed-off-by: Christoph Görn goern@redhat.com

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from goern after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/s2i-thoth/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
goern commented 2 years ago

/assign @harshad16 /assign @gregory-pereira

harshad16 commented 2 years ago

I think we should keep it , and note it in the readme, that we would not be upgrading anymore. how do you feel about this ?

goern commented 2 years ago

@harshad16 you are right. /close

sesheta commented 2 years ago

@goern: Closed this PR.

In response to [this](https://github.com/thoth-station/s2i-thoth/pull/255#issuecomment-1217961159): >@harshad16 you are right. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.