search

thoth-station / search

Visualize Python package metadata and browse advisory results.
https://thoth-station.ninja/search
GNU General Public License v3.0
6 stars 4 forks source link

check for no unmaintained packages #110

Closed Gkrumbach07 closed 1 year ago

Gkrumbach07 commented 1 year ago

Related Issues and Dependencies

n/a

This introduces a breaking change

This Pull Request implements

https://thoth-station.ninja/search/advise/adviser-221110165230-5736396adb425e9f/summary gives an error

Description

its failing because of an issue in the the timeline view card. it is expecting a param that isnt there. added check for param to be there

Gkrumbach07 commented 1 year ago

/approve

Gkrumbach07 commented 1 year ago

/lgtm

sesheta commented 1 year ago

@Gkrumbach07: you cannot LGTM your own PR.

In response to [this](https://github.com/thoth-station/search/pull/110#issuecomment-1310686845): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Gkrumbach07 commented 1 year ago

@harshad16 ready for review

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/search/blob/master/OWNERS)~~ [Gkrumbach07] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment