thoth-station / search

Visualize Python package metadata and browse advisory results.
https://thoth-station.ninja/search
GNU General Public License v3.0
6 stars 4 forks source link

atomic folder structure and added storybooks/chromatic #113

Closed Gkrumbach07 closed 1 year ago

Gkrumbach07 commented 1 year ago

Related Issues and Dependencies

fixes: https://github.com/thoth-station/search/issues/103

This introduces a breaking change

This Pull Request implements

Implemented an atomic folder structure. This breaks components down into independent parts that can be used on their own. This allows us to use storybooks and chromatic to test and visualize changes in single components without having to build the whole project.

Gkrumbach07 commented 1 year ago

Now every new PR in this repo gets a storybook published that can be viewed by navigating to the details of the Storybook Publish check.

PR reviewers can complete the UI Test checks by navigating to its respective details and reviewing the changes, commenting, denying, or accepting as necessary

Gkrumbach07 commented 1 year ago

/approve

Gkrumbach07 commented 1 year ago

/lgtm

sesheta commented 1 year ago

@Gkrumbach07: you cannot LGTM your own PR.

In response to [this](https://github.com/thoth-station/search/pull/113#issuecomment-1404013273): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
goern commented 1 year ago

/lgtm /approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07, goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/search/blob/master/OWNERS)~~ [Gkrumbach07,goern] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment