thoth-station / search

Visualize Python package metadata and browse advisory results.
https://thoth-station.ninja/search
GNU General Public License v3.0
6 stars 4 forks source link

[2pt] Direct / Root dependency counts swapped #83

Closed codificat closed 2 years ago

codificat commented 2 years ago

Describe the bug

It seems that the numbers for Direct and Root depencencies in the summary are reversed, i.e. Root is showing the number of direct dependencies, while Direct is showing the number of root level dependencies.

To Reproduce Steps to reproduce the behavior:

  1. Have a Pipfile with a single dependency on it, nltk
  2. Request a stack advise
  3. Check the advise results in the search UI
  4. Notice that the Dependencies Summary box shows wrong numbers

Expected behavior

There should be only 1 root package (nltk) and 4 direct (nltk's dependencies).

Screenshots

imatge

Additional context

Here is the advise I looked at: https://thoth-station.ninja/search/advise/adviser-220524121408-dc0af1f4d2307c27/summary

Gkrumbach07 commented 2 years ago

These metrics will be removed in a future update that better represents what the user wants to see. We will make sure to fix this issue when that happens.

/sig user-experience /kind bug /priority backlog

Gkrumbach07 commented 2 years ago

Acceptance criteria

/triage accepted

Gkrumbach07 commented 2 years ago

/close