Compare tab improvements

thoth-station / search

Visualize Python package metadata and browse advisory results.

https://thoth-station.ninja/search

GNU General Public License v3.0

6 stars 4 forks source link

Compare tab improvements #95

Closed TomasTomecek closed 2 years ago

TomasTomecek commented 2 years ago

Is your feature request related to a problem? Please describe. Just a list of things I'd improve in the output:

Drop down where I pick from the past advises: please show a real date or some meaningful information, IDs are hard to process by humans, e.g.
- adviser-220712133932-7d4aebd09e248cca - yuck
- 2022-07-12T13:39:47 security, RHEL-8.5 (Python 3.8.8) - I get that
Reorder sections: I personally don't care about internals, I care about the actual results: "Stack info" should be up, "Arguments" down
-, +, ~ - it took some time to understand the output. Mostly because I'm used to associating colors with the diff output: lines starting with + should be green, - red, ~ yellow

With these simple improvements, I'd say the Compare tab would be even more useful.

sesheta commented 2 years ago

@TomasTomecek: This issue is currently awaiting triage. One of the @thoth-station/devs will take care of the issue, and will accept the issue by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

Gkrumbach07 commented 2 years ago

/transfer-issue search /sig user-experience

Gkrumbach07 commented 2 years ago

Acceptance Criteria

[x] Use a friendly name in the drop down
[x] add color to the changed/added/removed lines
[x] prioritize stack info and justifications at the top or make a way to junk to specific sections
[x] add a way to link to a specific comparison i.e. '/compare/advise-###-####'
[x] Add toggle switch to only see differences

/triage accepted

harshad16 commented 2 years ago

Story point: 5pt /assign @Gkrumbach07

Gkrumbach07 commented 2 years ago

/close

sesheta commented 2 years ago

@Gkrumbach07: Closing this issue.

In response to [this](https://github.com/thoth-station/search/issues/95#issuecomment-1211930959): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.