Create a commit with report in a repo - Githubissues

thoth-station / slo-reporter

Provide report on Thoth Service Level Objectives (SLO) to stakeholders.

GNU General Public License v3.0

2 stars 7 forks source link

Create a commit with report in a repo #250

Open pacospace opened 3 years ago

pacospace commented 3 years ago

Is your feature request related to a problem? Please describe. As Maintainer/Manager,

I would like to see reports directly into a GitHub Repo.

The reports are currenty being sent via email and are not persisted in the repo

Describe the solution you'd like

[x] HTML report can be stored using env variable
[ ] Create/reuse a repo where to store HTML reports that are rendered.

Describe alternatives you've considered

Additional context cc @goern

Acceptance criteria

[ ] a commit is automatically created in the repo when the SLO reports are generated

goern commented 3 years ago

will we wrap this up in an argo workflow? 1. step to create the report, 2. commit? don't we have that functionality in other workflows?

pacospace commented 3 years ago

will we wrap this up in an argo workflow? 1. step to create the report, 2. commit? don't we have that functionality in other workflows?

Yes in the future wil be an argo CronWorkflow with different steps, as of now, a new method using source-management library

sesheta commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 3 years ago

@sesheta: Closing this issue.

In response to [this](https://github.com/thoth-station/slo-reporter/issues/250#issuecomment-880471768): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

sesheta commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 3 years ago

@sesheta: Closing this issue.

In response to [this](https://github.com/thoth-station/slo-reporter/issues/250#issuecomment-926236407): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

sesheta commented 2 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 2 years ago

@sesheta: Closing this issue.

In response to [this](https://github.com/thoth-station/slo-reporter/issues/250#issuecomment-952699759): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

codificat commented 2 years ago

this was auto-closed 1 month after reopening. I believe the intention was: /reopen /lifecycle frozen feel free to correct if that's not the case

sesheta commented 2 years ago

@codificat: Reopened this issue.

In response to [this](https://github.com/thoth-station/slo-reporter/issues/250#issuecomment-952876698): >this was auto-closed 1 month after reopening. I believe the intention was: >/reopen >/lifecycle frozen >feel free to correct if that's not the case Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

codificat commented 2 years ago

/sig observability /triage accepted

VannTen commented 1 year ago

Following the discussion in SIG meeting yesterday.

For metrics persistence, would we have the option to retain metrics longer ? (-> and have public dashboard / dashboard snapshots). I know Thanos can store metrics for long-term storage into object storage for example (S3), could that be an option ?

goern commented 1 year ago

revisiting the existing dashboards, and esp have the data stored in thanos, seems to be the right thing to do.