Update owners, pre-commit, and default URLs - Githubissues

thoth-station / slo-reporter

Provide report on Thoth Service Level Objectives (SLO) to stakeholders.

GNU General Public License v3.0

2 stars 7 forks source link

Update owners, pre-commit, and default URLs #346

Closed codificat closed 2 years ago

codificat commented 2 years ago

Related Issues and Dependencies

The default URL changes are related to #343.

This introduces a breaking change

No

This Pull Request implements

A few simple updates:

Change the default base URLs for Grafana and Superset to point to current Operate First hostnames
OWNERS: add myself replacing @pacospace and remove @fridex as reviewer (many thanks both!)
update pre-commit versions and remove redundant config

Description

Note that the URL change does not fully fix #343, because the e.g. dashboard names are currently hard-coded (e.g. https://github.com/thoth-station/slo-reporter/blob/68e3fa2f7043fb5c1c33b52f18342bb730daccce/thoth/slo_reporter/sli_references.py#L48) and they don't exist (by that name) in the destination.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16 To complete the pull request process, please assign pacospace after the PR has been reviewed. You can assign the PR to them by writing /assign @pacospace in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/slo-reporter/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment