Fixes: Mypy + pre-commit config

thoth-station / storages

Storage and database adapters for project Thoth

https://thoth-station.github.io/

GNU General Public License v3.0

14 stars 16 forks source link

Fixes: Mypy + pre-commit config #2737

Closed VannTen closed 2 years ago

VannTen commented 2 years ago

Update + fix pre-commit config
Fix flake8 pre-commit hooks
Fix mypy configuration
Apply https://github.com/hauntsaninja/no_implicit_optional
Fix mypy errors

VannTen commented 2 years ago

/retest-required

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mayaCostantini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/storages/blob/master/OWNERS)~~ [mayaCostantini] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mayaCostantini commented 2 years ago

@VannTen I think a fix is just needed at L#170 in the postgres.py file when importing PythonIndexNotRegistered (it should be PythonIndexNotRegisteredError).

mayaCostantini commented 2 years ago

/hold

VannTen commented 2 years ago

Looks like LSP renaming does not work super well :/

VannTen commented 2 years ago

@mayaCostantini still needs to hold ?

VannTen commented 2 years ago

/lgtm thanks +1

lgtm label apparently was not added. Might need to be on a line by itself, unless prow has a bug.

mayaCostantini commented 2 years ago

/unhold