:face_in_clouds: Fix the sync_documents formatting

thoth-station / storages

Storage and database adapters for project Thoth

https://thoth-station.github.io/

GNU General Public License v3.0

14 stars 16 forks source link

:face_in_clouds: Fix the sync_documents formatting #2751

Closed harshad16 closed 1 year ago

harshad16 commented 1 year ago

Fix the sync_documents formatting Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related Issues and Dependencies

Fixes: https://github.com/thoth-station/storages/issues/2750

This introduces a breaking change

[x] Yes
[ ] No

This should yield a new module release

[x] Yes
[ ] No

Description

Change dict.fromkeys to dict comprehension as dict.fromkeys behave weirdly when value is list. More info: https://stackoverflow.com/questions/3000468/unwanted-behaviour-from-dict-fromkeys
fix the handle assignment by changing the doc.rfind to doc.find , so it get correct prefix.
```
>>> x = "adviser-efa7213babd12911"
>>> x[x.rfind("/")+1: x.find("-")]
'adviser'
```
we would only like to run sync handlers if the document is having value or None.

goern commented 1 year ago

shall we merge this?!

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/storages/blob/master/OWNERS)~~ [codificat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

sesheta commented 1 year ago

@harshad16: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
aicoe-ci/prow/pytest	e4a9387df617dab18da4fcb8149d259b829772ca	link	true	`/test thoth-pytest-py38`
aicoe-ci/prow/pre-commit	e4a9387df617dab18da4fcb8149d259b829772ca	link	true	`/test pre-commit`

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

VannTen commented 1 year ago

/lgtm minus the pre-commit stuff

harshad16 commented 1 year ago

thanks all for the review Merging for the release.

VannTen commented 1 year ago

https://sentry.io/organizations/red-hat-it/issues/3881412534/?alert_rule_id=529086&alert_timestamp=1674010617326&alert_type=email&environment=ocp4-stage&project=1298083

Looks like we still have problems on that, and can't rely on clever string cutting...

VannTen commented 1 year ago

Or maybe we can with enough shoehorning ! :rofl: