search

thoth-station / storages

Storage and database adapters for project Thoth
https://thoth-station.github.io/
GNU General Public License v3.0
14 stars 16 forks source link

Add Pep as an approver / reviewer #2752

Closed codificat closed 1 year ago

codificat commented 1 year ago

This PR is to add myself to OWNERS as approver and reviewer.

Also removing Maya from the reviewers list to reduce her notifications a bit.

codificat commented 1 year ago

lets move maya to emeritus_approvers. wdyt ?

Ok for me, updated.

sesheta commented 1 year ago

@codificat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pytest 744c4eec84bf1a9366c0ee3b9960537bb443807d link true /test thoth-pytest-py38
aicoe-ci/prow/pre-commit 744c4eec84bf1a9366c0ee3b9960537bb443807d link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/storages/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment