search

thoth-station / support

ℹ Any Thoth related support questions
https://thoth-station.ninja/
0 stars 4 forks source link

container image mentioned contains outdated/wrong versions #204

Closed goern closed 2 years ago

goern commented 2 years ago

Describe the bug In https://redhat-scholars.github.io/managing-vulnerabilities-with-thoth/managing-vulnerabilities-with-thoth/01-run-application.html there is mentioned to use a container to run thamos, that container image has only python3.9 and thamos 1.21.1

Same is true for the master tag of https://quay.io/repository/thoth-station/s2i-thoth-f34-py39?tab=tags&tag=latest

To Reproduce Steps to reproduce the behavior:

  1. Go to https://redhat-scholars.github.io/managing-vulnerabilities-with-thoth/managing-vulnerabilities-with-thoth/01-run-application.html
  2. Execute docker run --rm -it --entrypoint bash quay.io/thoth-station/s2i-thoth-f34-py39:v0.32.3 # or use podman as mentioned
  3. Run thamos version in the container
  4. Run python --version in the container
  5. Run python.38 in the container
  6. See that py38 is required by .thoth.yaml

Expected behavior The container image used has the latest version of thamos and a version of Python3.8

Additional context n/a

/priority critical-urgent /assign @mayaCostantini

Gregory-Pereira commented 2 years ago

/triage accepted /assign

mayaCostantini commented 2 years ago

Addressed by https://github.com/redhat-scholars/managing-vulnerabilities-with-thoth/pull/38 and https://github.com/thoth-station/s2i-thoth/pull/238

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale