Thoth natively supports a differential analysis

thoth-station / support

ℹ Any Thoth related support questions

https://thoth-station.ninja/

0 stars 4 forks source link

Thoth natively supports a differential analysis #257

Closed TomasTomecek closed 2 years ago

TomasTomecek commented 2 years ago

Is your feature request related to a problem? Please describe.

As a Thoth user, I'd love to compare an advise of a PR with an advise done on the main branch easily with a single thamos advise command.

High-level Goals

Running advise produces results that only contain difference from a different advise. These are available both via Web UI and on CLI.

Describe the solution you'd like That's up to you :)

Additional context There already is a compare button in the Web UI. Sadly the past advises are not tagged in any way so it's hard to tell what to compare against.

Acceptance Criteria

Running thamos advise produces results with difference from another analysis.

sesheta commented 2 years ago

@TomasTomecek: This issue is currently awaiting triage. One of the @thoth-station/devs will take care of the issue, and will accept the issue by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

goern commented 2 years ago

/sig user-experience /priority important-soon

harshad16 commented 2 years ago

This is regarding having similar compare support in thamos. Acceptance criteria

[ ] Add additional command for compare of different advise analysis
[ ] Utilize the function of the git diff.
[ ] Figure the way to store the advise id (small term cache) for comparision.
[ ] Verify the result w.r.t to the search/compare.

Story Point: [Epic][13pt]

Gkrumbach07 commented 2 years ago

Acceptance Criteria Issues (covers points from https://github.com/thoth-station/support/issues/257#issuecomment-1194030035)

goern commented 2 years ago

/close as we work on it on

sesheta commented 2 years ago

@goern: Closing this issue.

In response to [this](https://github.com/thoth-station/support/issues/257#issuecomment-1212058101): >/close >as we work on it on Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.