search

thoth-station / template-project

This is a Template for any Python based project
GNU General Public License v3.0
7 stars 9 forks source link

Implement a pre-commit hook that checks for Pipfile/requirements.txt consistency #13

Closed fridex closed 3 years ago

fridex commented 4 years ago

Is your feature request related to a problem? Please describe.

To avoid issues like this one:

https://github.com/thoth-station/adviser/pull/1572#issuecomment-729578010 https://github.com/thoth-station/storages/pull/2101

we could develop a pre-commit hook that checks the consistency of these two files. Meaning - requirements in requirements.txt and Pipfile match.

Describe the solution you'd like

Develop a pre-commit hook to check the consistency of requirements.txt and Pipifle.

Describe alternatives you've considered

We have a bot for this - see https://github.com/thoth-station/kebechet/tree/master/kebechet/managers/pipfile_requirements This however, does not work well on PRs. It's more natural to gatet these type of errors in the CI on pull requests. The core logic of kebechet manager can be reused.

sesheta commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

fridex commented 3 years ago

/remove-lifecycle stale

goern commented 3 years ago

/label hacktoberfest /label "good first issue" /priority backlog /triage accepted

sesheta commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

fridex commented 3 years ago

/remove-lifecycle rotten /triage accepted

sesheta commented 3 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

sesheta commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

sesheta commented 3 years ago

@sesheta: Closing this issue.

In response to [this](https://github.com/thoth-station/template-project/issues/13#issuecomment-925605873): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.