search

thoth-station / thamos

A CLI tool and library for communicating with Thoth
http://thoth-station.ninja
GNU General Public License v3.0
15 stars 17 forks source link

Modify `_parse_labels` logic to allow specifying a list of values #1120

Closed mayaCostantini closed 2 years ago

mayaCostantini commented 2 years ago

Bug description

The logic to parse --labels should take into account having a list of values specified for a same label key, as in --labels allow-cve=PYSEC-2021-94,PYSEC-2021-2.

Steps to Reproduce

Run thamos with a list of values for a same label (see example above).

mayaCostantini commented 2 years ago

/priority critical-urgent /sig stack-guidance /assign

fridex commented 2 years ago

Is this related to some issue? Labels that are sent to the backend, in this case, should be:

{
    "allow-cve": "PYSEC-2021-94,PYSEC-2021-2"
}

Backend understands that allow-cve is a comma-separated list of CVEs to allow.

EDIT: I see your point, CLI option accepts , so it is not properly handled 👍🏻