thoth-station / thamos

A CLI tool and library for communicating with Thoth
http://thoth-station.ninja
GNU General Public License v3.0
15 stars 17 forks source link

added option to shorten results and reprint advise result table #1143

Closed Gkrumbach07 closed 2 years ago

Gkrumbach07 commented 2 years ago

Related Issues and Dependencies

fixes: https://github.com/thoth-station/thamos/issues/1118

This introduces a breaking change

This should yield a new module release

This Pull Request implements

This PR adds a new option for thamos advise named --short. This tag shortens the resulting output of an advise to only show the link to the Thoth Search page and a cumulative summary of the justification types.

Short Summary                                                                                                                                                      
The advise analysis fished with 19 INFO messages, 78 WARNING messages, and 0 ERROR messages.                                                                                                              
Results can be browsed in Thoth search: https://thoth-station.ninja/search/advise/adviser-220711195405-198a77724b0a055 

This PR also adds a new Thamos command: thamos results {analysis_id}. This command returns the table output of an advise run. Optionally you can provide a different _analysisid instead of using the last run analysis_id.

Description

I also condensed printing the table code into one function as multiple options use it now.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mayaCostantini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/thamos/blob/master/OWNERS)~~ [mayaCostantini] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment