thoth-station / thamos

A CLI tool and library for communicating with Thoth
http://thoth-station.ninja
GNU General Public License v3.0
15 stars 17 forks source link

[2pt] Add new thamos `diff` command #1147

Closed Gkrumbach07 closed 1 year ago

Gkrumbach07 commented 2 years ago

Problem statement

As a user of thamos, I want to be able to get the difference of two advise outputs.

High-level Goals

A new command thamos diff that takes one or two arguments and calls the function created by https://github.com/thoth-station/thamos/issues/1146.

Proposal description

The new command thamos diff should take one or two arguments.

thamos diff {old_id} {new_id}

This same functionality can also be triggered by adding the flag --diff to an advise command: thamos advise --diff. in this case, the difference is of the advise just run and the the most recent advise.

Additional context

This command would have to pull the advise documents using the provided ids or last run id. Getting the last run advise document will be similar to what thamos advise log does.

Acceptance Criteria

relies on: https://github.com/thoth-station/thamos/issues/1146.

Gkrumbach07 commented 2 years ago

/triage accepted

Gkrumbach07 commented 1 year ago

/close