filter option to results

thoth-station / thamos

A CLI tool and library for communicating with Thoth

http://thoth-station.ninja

GNU General Public License v3.0

15 stars 17 forks source link

filter option to results #1189

Closed Gkrumbach07 closed 1 year ago

Gkrumbach07 commented 1 year ago

Related Issues and Dependencies

fixes: https://github.com/thoth-station/thamos/issues/1129

This introduces a breaking change

This should yield a new module release

This Pull Request implements

Adds new options to thamos result

thamos result --filter type=INFO
thamos result --list-categories

Description

filter allows you to apply a regex matching pattern to any of the keys in the justifications
list-categories aggregates the types and prints the totals. When tags are added this will also be displayed

Gkrumbach07 commented 1 year ago

code climate complaining about too many arguments for a CLI command. I dont see any workaround to this. Can it be ignored and merged?

KPostOffice commented 1 year ago

code climate complaining about too many arguments for a CLI command. I dont see any workaround to this. Can it be ignored and merged?

Does making them kw only args fix it?

goern commented 1 year ago

/approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/thamos/blob/master/OWNERS)~~ [goern] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment