search

thoth-station / thamos

A CLI tool and library for communicating with Thoth
http://thoth-station.ninja
GNU General Public License v3.0
15 stars 17 forks source link

Fix set_runtime_environment with force enabled not updating the config correctly #1203

Closed mayaCostantini closed 1 year ago

mayaCostantini commented 1 year ago

Related Issues and Dependencies

Fixes: #908

This introduces a breaking change

This should yield a new module release

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from mayacostantini by writing /assign @mayacostantini in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/thamos/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
KPostOffice commented 1 year ago

Closing this as the issue isn't reproducible