thoth-station / thoth-application

Thoth-Station ArgoCD Applications
GNU General Public License v3.0
12 stars 22 forks source link

[3pt] create metrics for sync-job and set the requirements in manifests #2533

Closed harshad16 closed 1 year ago

harshad16 commented 2 years ago

As a Thoth Service Operator, I would like to have metrics from the sync-job so that we can create a dashboard from the syncs.

Acceptance criteria

harshad16 commented 2 years ago

/triage accepted /priority important-soon /sig devsecops

codificat commented 2 years ago

/kind feature

VannTen commented 1 year ago

@harshad16 for the second point : do we need to edit the four files with worklow ? :

 ls -l sync-job/base/
total 16
-rw-r--r-- 1 max max 1192 Jul 12 14:40 cron-workflow.yaml
-rw-r--r-- 1 max max  310 Jul 12 14:40 kustomization.yaml
-rw-r--r-- 1 max max 3268 Jul 12 14:40 workflow-template.yaml
-rw-r--r-- 1 max max 2055 Jul 12 14:40 workflow.yaml

? If not, which one (Argo / openshift pipelines If I read correctly)

harshad16 commented 1 year ago

For the second point, i meant to include the required env variable for the manifest files. for example cronjob: https://github.com/thoth-station/thoth-application/blob/12677b38c63bd96e5d1de3b8591b5f67594c2323/graph-refresh/overlays/aws-prod/cronjob.yaml#L80

VannTen commented 1 year ago

Completed by thoth-station/sync-job#73 and #2645