thoth-station / thoth-application

Thoth-Station ArgoCD Applications
GNU General Public License v3.0
12 stars 22 forks source link

send webhook container halts if the callback secret is not present #2677

Closed harshad16 closed 1 year ago

harshad16 commented 2 years ago

Describe the bug The new callback feature component send-webhook container halts for callback secrets as it is volume mounted. As the thamos sync based on user-api schema, the new thamos version would create default callback call on advise request. However old version wouldn't provide callback call, which would cause this issue.

Screenshot from 2022-10-07 14-30-45

To Reproduce Steps to reproduce the behavior:

  1. Execute a thamos advise from older version of thamos.
  2. Go to the cluster
  3. Scroll down to send-webhook container.
  4. See error

Expected behavior Smooth transition of send-webhook.

Possible solutions

Acceptance criteria

harshad16 commented 2 years ago

/sig devsecops /priority important-soon

harshad16 commented 2 years ago

/triage accepted