make callback secret optional

thoth-station / thoth-application

Thoth-Station ArgoCD Applications

GNU General Public License v3.0

12 stars 22 forks source link

make callback secret optional #2702

Closed KPostOffice closed 1 year ago

KPostOffice commented 1 year ago

if no requests have been made with callback secret combine, then no secret will exist, by making the secret optional the volume that is mounted will be empty and still allow the step to run

Signed-off-by: Kevin kpostlet@redhat.com

Related Issues and Dependencies

fixes: #2677

Does this require new deployment ?

[ ] Deployment for Test and Stage AICoE/aicoe-cd and Prod operate-first/argocd-apps.

KPostOffice commented 1 year ago

/hold

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/thoth-application/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment