search

thoth-station / thoth-application

Thoth-Station ArgoCD Applications
GNU General Public License v3.0
12 stars 22 forks source link

:face_in_clouds: Remove unused env var in graph-sync job #2727

Closed harshad16 closed 1 year ago

harshad16 commented 1 year ago

Remove unused env var in graph-sync job Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related Issues and Dependencies

Related-to: https://github.com/thoth-station/graph-sync-job/pull/678

codificat commented 1 year ago

/test kustomize-build

codificat commented 1 year ago

Should this also be removed from the job openshift template? https://github.com/thoth-station/thoth-application/blob/951f33db6f125803794e7d9812b1deffb7ed09db/graph-sync/base/openshift-templates/syncJob-template.yaml#L123-L127

harshad16 commented 1 year ago

Should this also be removed from the job openshift template?

https://github.com/thoth-station/thoth-application/blob/951f33db6f125803794e7d9812b1deffb7ed09db/graph-sync/base/openshift-templates/syncJob-template.yaml#L123-L127

yes, as removed in the pr

codificat commented 1 year ago

/lgtm /approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/thoth-application/blob/master/OWNERS)~~ [codificat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment