search

thoth-station / thoth-application

Thoth-Station ArgoCD Applications
GNU General Public License v3.0
12 stars 22 forks source link

:sleeping: Turn off sentry logging by removing sentry_dsn #2741

Closed harshad16 closed 1 year ago

harshad16 commented 1 year ago

:sleeping: Turn off sentry logging by removing sentry_dsn Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Description

As part of the hibernation of the project.

goern commented 1 year ago

as sentry_dsn is removed from the secrets, it will not be injected as an env var in deployments, and therefore thoth.logging will not send to sentry. correct?

harshad16 commented 1 year ago

as sentry_dsn is removed from the secrets, it will not be injected as an env var in deployments, and therefore thoth.logging will not send to sentry. correct?

as the value of sentry_dsn is removed, the env var SENTRY_DSN would fail in filter condition here https://github.com/thoth-station/common/blob/48e0bea82abccc4de312b193dd8771af7b8d4bf1/thoth/common/logging.py#L301 and would be noted as turned off https://github.com/thoth-station/common/blob/48e0bea82abccc4de312b193dd8771af7b8d4bf1/thoth/common/logging.py#L340

goern commented 1 year ago

/approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/thoth-application/blob/master/OWNERS)~~ [goern] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codificat commented 1 year ago

/lgtm