thoth-station / thoth-application

Thoth-Station ArgoCD Applications
GNU General Public License v3.0
12 stars 22 forks source link

Amun workflow can send message to Kafka to schedule graph-sync. [8pt] #398

Closed pacospace closed 3 years ago

pacospace commented 4 years ago

As User of Amun,

I would like to have the option to send a message to Kafka to know that an inspection ended succesfully, so that a consumer of that message can take action on that.

As Thoth User of Amun,

Beside steps above I want to use that message in investigator to schedule graph-sync job so that Thoth can learn about inspections.

Add to amun workflow:

with condition based on env variable to decide if the message need to be sent or not: THOTH_AMUN_SEND_MESSAGE

Reference discussion: https://github.com/thoth-station/thoth-application/issues/352

pacospace commented 4 years ago

/kind feature

KPostOffice commented 4 years ago

What should the contents of InspectionRunMessage be? and also I don't understand why we can't directly use GraphSync using the same conditional logic. @fridex @goern

fridex commented 4 years ago

What should the contents of InspectionRunMessage be?

The most important part is inspection_id so we know what inspection is finished.

and also I don't understand why we can't directly use GraphSync using the same conditional logic. @fridex @goern

Amun is a standalone component - we want to deploy it in different clusters with different HW to obtain inspection results. Then the message will notify a Thoth deployment that an inspection can be obtained and synced.

sesheta commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

fridex commented 3 years ago

This is duplicate of https://github.com/thoth-station/amun-api/issues/552

sesheta commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

goern commented 3 years ago

/triage duplicate /close

sesheta commented 3 years ago

@goern: Closing this issue.

In response to [this](https://github.com/thoth-station/thoth-application/issues/398#issuecomment-858731261): >/triage duplicate >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.