thoth-station / thoth-ops-infra

Infrastructure project to have collections of container images.
GNU General Public License v3.0
0 stars 9 forks source link

[1pt] modules with jupyter_packaging fails during pytest in prow because of setuptools in wrong version #50

Closed pacospace closed 2 years ago

pacospace commented 2 years ago

Is your feature request related to a problem? Please describe.

Traceback (most recent call last):
  File "setup.py", line 7, in <module>
    from jupyter_packaging import create_cmdclass, install_npm, ensure_targets, combine_commands
  File "/opt/app-root/lib64/python3.8/site-packages/jupyter_packaging/__init__.py", line 6, in <module>
    from .setupbase import *
  File "/opt/app-root/lib64/python3.8/site-packages/jupyter_packaging/setupbase.py", line 37, in <module>
    from setuptools.config import StaticModule
ImportError: cannot import name 'StaticModule' from 'setuptools.config' (/opt/app-root/lib64/python3.8/site-packages/setuptools/config.py)
Aborting due to errexit on line 14. Exit code: 1

Describe the solution you'd like Have image with "setuptools>=46.4.0" See comment from Jupyter maintainers: https://githubmemory.com/repo/jupyter/notebook/issues/6056

Describe alternatives you've considered

Additional context

pacospace commented 2 years ago

from quay.io/thoth-station/thoth-pytest-py38:v0.13.0 container

(app-root) pip show setuptools
Name: setuptools
Version: 41.6.0
Summary: Easily download, build, install, upgrade, and uninstall Python packages
Home-page: https://github.com/pypa/setuptools
Author: Python Packaging Authority
Author-email: distutils-sig@python.org
License: UNKNOWN
Location: /opt/app-root/lib/python3.8/site-packages
Requires: 
Required-by: thoth-python, thamos, kubernetes, jsonschema, google-auth
(app-root) 
goern commented 2 years ago

does this problem still exist with v0.14.3?

/kind bug /priority critical-urgent /remove-label kind/feature

sesheta commented 2 years ago

@goern: The label(s) /remove-label kind/feature cannot be applied. These labels are supported: community/discussion, community/group-programming, community/maintenance, community/question, deployment_name/ocp4-stage, deployment_name/ocp4-test, deployment_name/moc-prod, hacktoberfest, hacktoberfest-accepted, kind/cleanup, kind/demo, kind/deprecation, kind/documentation, kind/question, sig/advisor, sig/build, sig/cyborgs, sig/devops, sig/documentation, sig/indicators, sig/investigator, sig/knowledge-graph, sig/slo, sig/solvers, thoth/group-programming, thoth/human-intervention-required, thoth/potential-observation, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, triage/accepted, triage/duplicate, triage/needs-information, triage/not-reproducible, triage/unresolved, lifecycle/submission-accepted, lifecycle/submission-rejected

In response to [this](https://github.com/thoth-station/thoth-ops-infra/issues/50#issuecomment-1041299132): >does this problem still exist with v0.14.3? > >/kind bug >/priority critical-urgent >/remove-label kind/feature Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
goern commented 2 years ago

is this still relevant? /priority important-soon

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

sesheta commented 2 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

harshad16 commented 2 years ago

/remove-lifecycle rotten /lifecycle active /triage accepted /sig devsecops