search

thoth-station / thoth-ops-infra

Infrastructure project to have collections of container images.
GNU General Public License v3.0
0 stars 9 forks source link

[1pt] Update the requirements and turn on the kebechet #58

Closed harshad16 closed 2 years ago

harshad16 commented 2 years ago

Is your feature request related to a problem? Please describe. Many of the components are on old version of the packages, for exaple: mypy, pre-commit etc. Lets update them and iterate over the release.

Describe the solution you'd like Manully update of now and turn on kebechet.

harshad16 commented 2 years ago

/triage accepted /sig devsecops /lifecycle active /priority important-soon

harshad16 commented 2 years ago

Kebechet update is failing in this repo due to below issue:

2022-07-06 19:15:46,855   1 ERROR    kebechet:214: An error occurred during run of manager {'configuration': {}} <class 'kebechet.managers.update.update.UpdateManager'> for 'thoth-station/thoth-ops-infra', skipping
Traceback (most recent call last):
  File "/home/user/kebechet/kebechet_runners.py", line 212, in run
    instance.run(**manager_configuration)
TypeError: run() missing 1 required positional argument: 'labels'
2022-07-06 19:15:52,115   1 INFO     kebechet:196: Running manag

Tried with issue: #60

codificat commented 2 years ago

It seems to me that this was fixed by #59 - it was actually referenced in the description there that it fixes this issue, not sure why it was not auto-closed... maybe you have to specify each Fixes: XX in its own separate line?

/close

Please reopen if I read this wrong

sesheta commented 2 years ago

@codificat: Closing this issue.

In response to [this](https://github.com/thoth-station/thoth-ops-infra/issues/58#issuecomment-1211720982): >It seems to me that this was fixed by #59 - it was actually referenced in the description there that it fixes this issue, not sure why it was not auto-closed... maybe you have to specify each `Fixes: XX` in its own separate line? > >/close > >Please reopen if I read this wrong Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codificat commented 2 years ago

Oh, I now think I spoke too soon, this seems not completely fixed yet: Kebechet is complaining that there is no Pipfile or requirements.txt to work with, see #63

However, not reopening this now as it would duplicate #63 - let's use that to track that problem.