search

thoth-station / workflow-helpers

All code required to help workflows (e.g Argo).
GNU General Public License v3.0
3 stars 10 forks source link

Refactor control flow in common.store_messages #426

Open VannTen opened 1 year ago

VannTen commented 1 year ago

See https://github.com/thoth-station/workflow-helpers/pull/424#issuecomment-1259229936

https://github.com/thoth-station/workflow-helpers/blob/master/thoth/workflow_helpers/common.py#L70-L82

Since this is normal operation, we should get probably rid of the exception-as-control-flow.

/kind cleanup /kind backlog /sig stack-guidance /good-first-issue

Acceptance critera:

sesheta commented 1 year ago

@VannTen: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/thoth-station/workflow-helpers/issues/426): >See https://github.com/thoth-station/workflow-helpers/pull/424#issuecomment-1259229936 > >https://github.com/thoth-station/workflow-helpers/blob/master/thoth/workflow_helpers/common.py#L70-L82 > >Since this is normal operation, we should get **probably** rid of the >exception-as-control-flow. > >/kind cleanup >/kind backlog >/sig stack-guidance >/good-first-issue > >Acceptance critera: >- [ ] Refactor the mentionned code >OR >- [ ] Explain how such a refactor would add unnecessary complexity (in this > issue discussion) > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sesheta commented 1 year ago

@VannTen: The label(s) kind/backlog cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/thoth-station/workflow-helpers/issues/426): >See https://github.com/thoth-station/workflow-helpers/pull/424#issuecomment-1259229936 > >https://github.com/thoth-station/workflow-helpers/blob/master/thoth/workflow_helpers/common.py#L70-L82 > >Since this is normal operation, we should get **probably** rid of the >exception-as-control-flow. > >/kind cleanup >/kind backlog >/sig stack-guidance >/good-first-issue > >Acceptance critera: >- [ ] Refactor the mentionned code >OR >- [ ] Explain how such a refactor would add unnecessary complexity (in this > issue discussion) > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
VannTen commented 1 year ago

/priority backlog