search

thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:S00122, squid:S1301, squid:SwitchLastCaseIsDefaultCheck, squid:S1854, squid:CommentedOutCodeLine, squid:UselessParenthesesCheck #74

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S00122 - Statements should be on separate lines. squid:S1301 - "switch" statements should have at least 3 "case" clauses. squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause. squid:S1854 - Dead stores should be removed. squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S1301 https://dev.eclipse.org/sonar/rules/show/squid:SwitchLastCaseIsDefaultCheck https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thank you for your help