search

thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:S00122, squid:S1192, squid:S1118, squid:CommentedOutCodeLine, squid:S00117, squid:S1905, squid:S1066, squid:S2094, squid:S2864, squid:S1155 #75

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S00122 - Statements should be on separate lines. squid:S1192 - String literals should not be duplicated. squid:S1118 - Utility classes should not have public constructors. squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S00117 - Local variable and method parameter names should comply with a naming convention. squid:S1905 - Redundant casts should not be used. squid:S1066 - Collapsible "if" statements should be merged. squid:S2094 - Classes should not be empty. squid:S2864 - "entrySet()" should be iterated when both the key and value are needed. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S1192 https://dev.eclipse.org/sonar/rules/show/squid:S1118 https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S00117 https://dev.eclipse.org/sonar/rules/show/squid:S1905 https://dev.eclipse.org/sonar/rules/show/squid:S1066 https://dev.eclipse.org/sonar/rules/show/squid:S2094 https://dev.eclipse.org/sonar/rules/show/squid:S2864 https://dev.eclipse.org/sonar/rules/show/squid:S1155 Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thank you for your fixes