thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:S1118, squid:S1149, squid:S00122, squid:S1192, squid:S1481, squid:S1854, squid:CommentedOutCodeLine, squid:S1125, squid:S1155, squid:UselessParenthesesCheck #76

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1118 - Utility classes should not have public constructors. squid:S1149 - Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used. squid:S00122 - Statements should be on separate lines. squid:S1192 - String literals should not be duplicated. squid:S1481 - Unused local variables should be removed. squid:S1854 - Dead stores should be removed. squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S1125 - Literal boolean values should not be used in condition expressions. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1118 https://dev.eclipse.org/sonar/rules/show/squid:S1149 https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S1192 https://dev.eclipse.org/sonar/rules/show/squid:S1481 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S1125 https://dev.eclipse.org/sonar/rules/show/squid:S1155 https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thank you for your help