thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:CommentedOutCodeLine, squid:S1905, squid:S1854, squid:S1066, squid:S2184, squid:S1481, squid:S2681, squid:SwitchLastCaseIsDefaultCheck, squid:S00117, squid:S00122, squid:S2786 #79

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S1905 - Redundant casts should not be used. squid:S1854 - Dead stores should be removed. squid:S1066 - Collapsible "if" statements should be merged. squid:S2184 - Math operands should be cast before assignment. squid:S1481 - Unused local variables should be removed. squid:S2681 - Multiline blocks should be enclosed in curly braces. squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause. squid:S00117 - Local variable and method parameter names should comply with a naming convention. squid:S00122 - Statements should be on separate lines. squid:S2786 - Nested "enum"s should not be declared static. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S1905 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S1066 https://dev.eclipse.org/sonar/rules/show/squid:S2184 https://dev.eclipse.org/sonar/rules/show/squid:S1481 https://dev.eclipse.org/sonar/rules/show/squid:S2681 https://dev.eclipse.org/sonar/rules/show/squid:SwitchLastCaseIsDefaultCheck https://dev.eclipse.org/sonar/rules/show/squid:S00117 https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S2786 Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thank you for your fixes dude