thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:S1481, squid:S1854, squid:S2185, squid:S1905, squid:UselessParenthesesCheck, squid:S1192, squid:S1213, squid:S2131, squid:S1155 #81

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1481 - Unused local variables should be removed. squid:S1854 - Dead stores should be removed. squid:S2185 - Silly math should not be performed. squid:S1905 - Redundant casts should not be used. squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. squid:S1192 - String literals should not be duplicated. squid:S1213 - The members of an interface declaration or class should appear in a pre-defined order. squid:S2131 - Primitives should not be boxed just for "String" conversion. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1481 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S2185 https://dev.eclipse.org/sonar/rules/show/squid:S1905 https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck https://dev.eclipse.org/sonar/rules/show/squid:S1192 https://dev.eclipse.org/sonar/rules/show/squid:S1213 https://dev.eclipse.org/sonar/rules/show/squid:S2131 https://dev.eclipse.org/sonar/rules/show/squid:S1155 Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thanks for this