Closed georgekankava closed 8 years ago
This pull request is focused on resolving occurrences of Sonar rules squid:S2786 - Nested "enum"s should not be declared static. squid:S1192 - String literals should not be duplicated. squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. squid:S1125 - Literal boolean values should not be used in condition expressions. squid:S00122 - Statements should be on separate lines. squid:S1854 - Dead stores should be removed. squid:S1481 - Unused local variables should be removed. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. squid:S1066 - Collapsible "if" statements should be merged. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S2786 https://dev.eclipse.org/sonar/rules/show/squid:S1192 https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck https://dev.eclipse.org/sonar/rules/show/squid:S1125 https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S1481 https://dev.eclipse.org/sonar/rules/show/squid:S1155 https://dev.eclipse.org/sonar/rules/show/squid:S1066 Please let me know if you have any questions. George Kankava
Thank you for fixes
thothbot
commented
8 years ago thothbot
commented
8 years ago
This pull request is focused on resolving occurrences of Sonar rules squid:S2786 - Nested "enum"s should not be declared static. squid:S1192 - String literals should not be duplicated. squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. squid:S1125 - Literal boolean values should not be used in condition expressions. squid:S00122 - Statements should be on separate lines. squid:S1854 - Dead stores should be removed. squid:S1481 - Unused local variables should be removed. squid:S1155 - Collection.isEmpty() should be used to test for emptiness. squid:S1066 - Collapsible "if" statements should be merged. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S2786 https://dev.eclipse.org/sonar/rules/show/squid:S1192 https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck https://dev.eclipse.org/sonar/rules/show/squid:S1125 https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S1854 https://dev.eclipse.org/sonar/rules/show/squid:S1481 https://dev.eclipse.org/sonar/rules/show/squid:S1155 https://dev.eclipse.org/sonar/rules/show/squid:S1066 Please let me know if you have any questions. George Kankava