thothbot / parallax

Cross-platform Java 3D SDK
http://thothbot.github.io
MIT License
84 stars 26 forks source link

multiple code improvements: squid:S1192, squid:CommentedOutCodeLine, squid:S1066, squid:S2185, squid:S00122, squid:S1905, squid:S00117, squid:UselessParenthesesCheck #83

Closed georgekankava closed 8 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:S1192 - String literals should not be duplicated. squid:CommentedOutCodeLine - Sections of code should not be "commented out". squid:S1066 - Collapsible "if" statements should be merged. squid:S2185 - Silly math should not be performed. squid:S00122 - Statements should be on separate lines. squid:S1905 - Redundant casts should not be used. squid:S00117 - Local variable and method parameter names should comply with a naming convention. squid:UselessParenthesesCheck - Useless parentheses around expressions should be removed to prevent any misunderstanding. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1192 https://dev.eclipse.org/sonar/rules/show/squid:CommentedOutCodeLine https://dev.eclipse.org/sonar/rules/show/squid:S1066 https://dev.eclipse.org/sonar/rules/show/squid:S2185 https://dev.eclipse.org/sonar/rules/show/squid:S00122 https://dev.eclipse.org/sonar/rules/show/squid:S1905 https://dev.eclipse.org/sonar/rules/show/squid:S00117 https://dev.eclipse.org/sonar/rules/show/squid:UselessParenthesesCheck Please let me know if you have any questions. George Kankava

thothbot commented 8 years ago

Thank you for your help